get url form DOCKER_COMPOSE_DOWNLOAD_LINK if exist #305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 22.90% 22.90%
=======================================
Files 15 15
Lines 1275 1275
=======================================
Hits 292 292
Misses 964 964
Partials 19 19 Continue to review full report at Codecov.
|
get url form DOCKER_COMPOSE_DOWNLOAD_LINK if exist Signed-off-by: MaxPeal <[email protected]>
Signed-off-by: MaxPeal <[email protected]>
Signed-off-by: MaxPeal <[email protected]>
There was a problem hiding this comment.
Hello! Thank you @MaxPeal for your contribution! And welcome!!
A few things:
- Do you mind explaining why you are introducing a new option in the
setup.sh? You can write itWhy is this neededthe current section does not really explain to me why you need that variable. - Do you mind to squash your commits in a single one?
- We use (shellcheck)[https://www.shellcheck.net/] to statically analyze bash scrits. Your changes are currently not complaint. Do you mind to fix them?
Signed-off-by: MaxPeal <[email protected]>
Signed-off-by: MaxPeal <[email protected]>
| @@ -16,12 +40,17 @@ setup_docker() ( | |||
| gnupg-agent \ | |||
| software-properties-common | |||
|
|
|||
| curl -fsSL https://download.docker.com/linux/ubuntu/gpg | | |||
| local lsb_dist | |||
There was a problem hiding this comment.
This work to support other LSB distributions should be moved to a separate PR.
|
Fixes #518 |
|
I've opened a new rebased, conflict merged, PR with some of the changes from this PR, @MaxPeal. See #519 Any vagrant work will need to be moved to tinkerbell/sandbox. I created an issue to track that #518, but closed it when I realized that vagrant was removed from this repo. Closing this PR in favor of #519. |
## Description Rebase of #305 (@MaxPeal) with reviewer requested changes applied. notably, this variation on the original PR does not include `curl --progress`. ## Why is this needed Fixes: #306 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## How are existing users impacted? What migration steps/scripts do we need? <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Description
get url form DOCKER_COMPOSE_DOWNLOAD_LINK if exist
Why is this needed
to doit on the same way like the setup.sh
Fixes: #
How Has This Been Tested?
just testit it localy
How are existing users impacted? What migration steps/scripts do we need?
no migration steps needed