Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed context path in docker-compose.yml #307

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

gauravgahlot
Copy link
Contributor

Description

PR fixes the context path for tink-server and tink-cli in docker-compose.yml

Why is this needed

docker-compose fails to bring up the stack with the fix.

How Has This Been Tested?

Tested with local vagrant setup.

@gauravgahlot gauravgahlot self-assigned this Sep 24, 2020
@gauravgahlot gauravgahlot changed the title Fix context path in docker-compose.yml Fixed context path in docker-compose.yml Sep 24, 2020
@gauravgahlot gauravgahlot added the size/XS estimate of the amount of work to address the issue label Sep 24, 2020
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          15       15           
  Lines        1275     1275           
=======================================
  Hits          292      292           
  Misses        964      964           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb06ccd...15d323c. Read the comment docs.

@Cbkhare Cbkhare self-requested a review September 24, 2020 05:43
@mergify mergify bot merged commit 0678cbc into tinkerbell:master Sep 24, 2020
@gauravgahlot gauravgahlot deleted the context-path branch September 28, 2020 06:19
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS estimate of the amount of work to address the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants