Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Apply migrations when tink-server boots" #310

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Sep 28, 2020

Reverts #296

I have to rever this PR because we merged it too early. I don't have a good story yet for what concerns "how to apply migration" in sandbox or with docker compose.

@gianarb gianarb requested a review from mmlb September 28, 2020 16:19
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Sep 28, 2020
@gianarb gianarb force-pushed the revert-296-feature/migrate branch from d92c531 to e67eead Compare September 28, 2020 16:20
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #310 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   22.91%   22.90%   -0.02%     
==========================================
  Files          15       15              
  Lines        1274     1275       +1     
==========================================
  Hits          292      292              
- Misses        963      964       +1     
  Partials       19       19              
Impacted Files Coverage Δ
grpc-server/grpc_server.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bd870...e67eead. Read the comment docs.

@mergify mergify bot merged commit fdbf00a into master Sep 28, 2020
@mergify mergify bot deleted the revert-296-feature/migrate branch September 28, 2020 16:25
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants