Cheerful tweaks #311
Merged
Cheerful tweaks #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 15 15
Lines 1271 1271
=======================================
Hits 288 288
Misses 964 964
Partials 19 19 Continue to review full report at Codecov.
|
mmlb
force-pushed
the
cheerful-tweaks
branch
from
d357fb4 to
2c0c18d
Compare
Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
These args ensure we exit on error conditions and don't pollute logs with weird single character/progress lines. Signed-off-by: Manuel Mendez <[email protected]>
This will be the main way to check and install os packages. Signed-off-by: Manuel Mendez <[email protected]>
curl is used in setup_docker and setup_docker_compose so we should install it in main instead of in setup_docker. Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
Makes main easier to follow. Signed-off-by: Manuel Mendez <[email protected]>
To better reflect new code. Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
cheerful-tweaks
branch
from
2c0c18d to
961007b
Compare
gianarb
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor tweaks to files throughout the project.
How Has This Been Tested?
Run through vagrant
How are existing users impacted? What migration steps/scripts do we need?
No impact.