Quay login only works if commit is in master #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 23.79% 23.79%
=======================================
Files 14 14
Lines 1244 1244
=======================================
Hits 296 296
Misses 928 928
Partials 20 20 Continue to review full report at Codecov.
|
GitHub Action environment variables gets passed to PR only if they starts from a branch that is local, so fork does not get a QUAY PASSOWRD and USERNAME, this is to avoid security issue. GitHub is working at it but for now that's what we have. We push images to Quay only if the commit is in master, but during a re-work of the GitHub Action we login all the time. And that's a bug. Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
force-pushed
the
hotfix/ci-hub-login-on-mater
branch
from
8d0fb91 to
0cd07a0
Compare
kqdeng
approved these changes
Oct 19, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Action environment variables gets passed to PR only if they
starts from a branch that is local, so fork does not get a QUAY PASSOWRD
and USERNAME, this is to avoid security issue.
GitHub is working at it but for now that's what we have.
We push images to Quay only if the commit is in master, but during a
re-work of the GitHub Action we login all the time. And that's a bug.
Fixes CI for #342