Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tink-cli #354

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix tink-cli #354

merged 1 commit into from
Oct 29, 2020

Conversation

kqdeng
Copy link
Contributor

@kqdeng kqdeng commented Oct 29, 2020

Signed-off-by: Kelly Deng [email protected]

Description

Fixes the tink-cli's Dockerfile

Why is this needed

The recent merge of PR #323 introduced a bug where the tink-cli container would keep restarting on create.

root@tink02-provisioner:~/tink/deploy# docker ps
CONTAINER ID        IMAGE                                                                   COMMAND                  CREATED             STATUS                        PORTS                                  NAMES
0733f33c8ad8        quay.io/tinkerbell/tink-cli:latest                                      "/usr/bin/tink-cli"      6 seconds ago       Restarting (0) 1 second ago                                          deploy_tink-cli_1

Fixes: #

How Has This Been Tested?

Tested manually

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Kelly Deng <[email protected]>
@kqdeng kqdeng requested a review from gianarb October 29, 2020 01:38
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   23.79%   23.79%           
=======================================
  Files          14       14           
  Lines        1244     1244           
=======================================
  Hits          296      296           
  Misses        928      928           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cc2e2...c66a201. Read the comment docs.

@gianarb gianarb merged commit 589d28a into tinkerbell:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants