Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login to quay only in master #355

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Fix login to quay only in master #355

merged 1 commit into from
Oct 29, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Oct 29, 2020

The login to Quay has to happen only for commits landing to master

@gianarb gianarb requested a review from thebsdbox October 29, 2020 08:19
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   23.79%   23.79%           
=======================================
  Files          14       14           
  Lines        1244     1244           
=======================================
  Hits          296      296           
  Misses        928      928           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589d28a...b22c647. Read the comment docs.

The login to Quay has to happen only for commits landing to master

Signed-off-by: Gianluca Arbezzano <[email protected]>
@thebsdbox
Copy link
Contributor

/lgtm - my only question is, are we renaming master to something else?

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Oct 29, 2020
@gianarb gianarb merged commit 18498f3 into tinkerbell:master Oct 29, 2020
@gianarb
Copy link
Contributor Author

gianarb commented Oct 29, 2020

I have no idea @thebsdbox

@gianarb gianarb deleted the hotfix/quay-only-master branch October 29, 2020 09:15
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants