Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compose now that we build binaries in Docker #356

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Fix compose now that we build binaries in Docker #356

merged 2 commits into from
Oct 29, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Oct 29, 2020 •
edited by gauravgahlot
Loading

Tested it with the local vagrant setup:

vagrant@provisioner:/vagrant/deploy$ docker-compose ps
             Name                           Command                  State                             Ports                       
-----------------------------------------------------------------------------------------------------------------------------------
deploy_boots_1                   /usr/bin/boots -dhcp-addr  ...   Up                                                               
deploy_db_1                      docker-entrypoint.sh postgres    Up (healthy)   0.0.0.0:5432->5432/tcp                            
deploy_hegel_1                   /usr/bin/hegel                   Up                                                               
deploy_nginx_1                   /docker-entrypoint.sh ngin ...   Up             192.168.1.2:80->80/tcp                            
deploy_registry_1                /entrypoint.sh /etc/docker ...   Up (healthy)                                                     
deploy_tink-cli_1                /bin/sh -c sleep infinity        Up                                                               
deploy_tink-server-migration_1   /usr/bin/tink-server             Exit 0                                                           
deploy_tink-server_1             /usr/bin/tink-server             Up (healthy)   0.0.0.0:42113->42113/tcp, 0.0.0.0:42114->42114/tcp

Fix compose now that we build binaries in Docker
7c231f0 
Docker Compose is not working in tink, now that we started building
binaries as part of the Dockerfile and not outside

This should fix the issue

Signed-off-by: Gianluca Arbezzano <[email protected]>
@gianarb gianarb force-pushed the hotfix/docker-compose branch from 8d0846b to 7c231f0 Compare October 29, 2020 11:22
@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   23.79%   23.79%           
=======================================
  Files          14       14           
  Lines        1244     1244           
=======================================
  Hits          296      296           
  Misses        928      928           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18498f3...babf08d. Read the comment docs.

@gauravgahlot
Corrected path to Dockerfile
babf08d 
Signed-off-by: Gaurav Gahlot <[email protected]>
@gauravgahlot gauravgahlot force-pushed the hotfix/docker-compose branch from 4a196ec to babf08d Compare October 29, 2020 11:52
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Oct 29, 2020
parauliya
parauliya approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@parauliya parauliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot merged commit 322775a into master Oct 29, 2020
@gauravgahlot gauravgahlot deleted the hotfix/docker-compose branch October 29, 2020 12:28
@gauravgahlot gauravgahlot removed the request for review from Cbkhare October 29, 2020 12:29
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parauliya parauliya parauliya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gianarb @parauliya @mmlb @gauravgahlot