Remove hard coded role and db name from init db migration #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
previously approved these changes
Nov 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 24.74% 24.74%
=======================================
Files 14 14
Lines 1277 1277
=======================================
Hits 316 316
Misses 940 940
Partials 21 21 Continue to review full report at Codecov.
|
splaspood
force-pushed
the
db-migration-k8s-0
branch
from
996d72b to
c597b61
Compare
mmlb
suggested changes
Nov 6, 2020
There was a problem hiding this comment.
@splaspood you need to update the docker-compose.yml so it creates the db
Signed-off-by: James W. Brinkerhoff <[email protected]>
Signed-off-by: James W. Brinkerhoff <[email protected]>
splaspood
force-pushed
the
db-migration-k8s-0
branch
from
077c433 to
5d2ea7a
Compare
mmlb
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initial database migration currently has a hard coded database name and role. This change removes both.
Why is this needed
This prevents us from deploying tink against a database that happens to utilize a different role or db name.
Checklist:
I have: