Avoid using context.TODO() in unit tests #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gahlot <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 24.74% 24.74%
=======================================
Files 14 14
Lines 1277 1277
=======================================
Hits 316 316
Misses 940 940
Partials 21 21 Continue to review full report at Codecov.
|
Cbkhare
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gahlot [email protected]
Description
It is not a good practice to use a never-ending context in unit tests. It is suggested that a unit test should always have a timeout.
How Has This Been Tested?
make testHow are existing users impacted? What migration steps/scripts do we need?
No impact.