fix getting template by name not returning the associated id #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kelly Deng <[email protected]>
kqdeng
force-pushed
the
fix-query-by-name
branch
from
ce621e2 to
57b0b1e
Compare
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
=======================================
Coverage 24.74% 24.74%
=======================================
Files 14 14
Lines 1277 1277
=======================================
Hits 316 316
Misses 940 940
Partials 21 21
Continue to review full report at Codecov.
|
mmlb
approved these changes
Nov 13, 2020
| } | ||
| if fields["name"] == templateName1 { | ||
| return "", template1, nil |
There was a problem hiding this comment.
These 2 if statements can be combined as one.
| @@ -58,8 +58,8 @@ func TestCreateWorkflow(t *testing.T) { | |||
| "FailedCreatingWorkflow": { | |||
| args: args{ | |||
| db: mock.DB{ | |||
| GetTemplateFunc: func(ctx context.Context, fields map[string]string) (string, string, error) { | |||
| return "", templateData, nil | |||
| GetTemplateFunc: func(ctx context.Context, fields map[string]string) (string, string, string, error) { | |||
There was a problem hiding this comment.
Instead of returning an empty string, maybe we can return a pre-defined name for mock (e.g., MockedTemplate?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetching a template by name now also returns the associated ID.
Why is this needed
A recent PR #349 added the functionality of fetching a template by name. The returned template is expected to include the ID, name, and template data. However, currently, it would only return the name and the template data. The returned ID is just an empty string.
How Has This Been Tested?
Manually
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: