Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cachix/install-nix-action to v12 #370

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

kqdeng
Copy link
Contributor

@kqdeng kqdeng commented Nov 18, 2020

Signed-off-by: Kelly Deng [email protected]

Description

Bumps cachix/install-nix-action from v10 to v12 (latest version)

Why is this needed

Github actions deprecated the add-path command and install-nix-action v10 indirectly used that command, which fails the action. Upgrading to v12 fixes that issue.

Fixes: #

How Has This Been Tested?

All checks now pass

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #370 (186ed99) into master (5cbbeec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   24.74%   24.74%           
=======================================
  Files          14       14           
  Lines        1277     1277           
=======================================
  Hits          316      316           
  Misses        940      940           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cbbeec...186ed99. Read the comment docs.

Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Nov 18, 2020
@gianarb gianarb merged commit 23c4fb0 into tinkerbell:master Nov 18, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants