Remove global logger from db package #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
force-pushed
the
chore/remove-global-logger-for-db
branch
2 times, most recently
from
02e4b71 to
b11e2ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 28.73% 28.73%
=======================================
Files 19 19
Lines 1385 1385
=======================================
Hits 398 398
Misses 960 960
Partials 27 27 Continue to review full report at Codecov.
|
I am working on a integration test suite for the db package. And the global logger is not an ideal approach in any case. This PR moves the logger from package level to TinkDB Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
force-pushed
the
chore/remove-global-logger-for-db
branch
from
b11e2ee to
cc8addd
Compare
thebsdbox
approved these changes
Dec 11, 2020
|
The logger is the same or should be the same across the application, but having a global variable at the package level makes testing hard and I am currently having a look at how we can test the db pkg #387 that's where this PR comes from :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a integration test suite for the db package. And the
global logger is not an ideal approach in any case.
This PR moves the logger from package level to TinkDB