Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: Remove hard coded role in 202010071530. #392

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Dec 14, 2020

Description

The hardcoded role and db names were removed in e746c25. This PR exists
from before then and I missed this when re-reviewing the PR before
merging.

The hardcoded role and db names were removed in e746c25. This PR exists
from before then and I missed this when re-reviewing the PR before
merging.

Signed-off-by: Manuel Mendez <[email protected]>
@mmlb mmlb force-pushed the remove-role-from-events-migration branch from aa82183 to f3d421d Compare December 14, 2020 20:44
@mmlb mmlb requested a review from splaspood December 14, 2020 20:44
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #392 (f3d421d) into master (492f9c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   28.71%   28.71%           
=======================================
  Files          19       19           
  Lines        1386     1386           
=======================================
  Hits          398      398           
  Misses        961      961           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492f9c7...f3d421d. Read the comment docs.

@mergify mergify bot merged commit 266637a into tinkerbell:master Dec 14, 2020
@mmlb mmlb deleted the remove-role-from-events-migration branch December 14, 2020 20:58
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants