Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nat for workers #31 #410

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

Cbkhare
Copy link
Contributor

@Cbkhare Cbkhare commented Jan 4, 2021

Description

Provisioner NAT setup for workers

Why is this needed

internet access on workers. tinkerbell/playground#31

Fixes: #

How Has This Been Tested?

  • workflow executed successfully.
  • ping from workers works correctly.

Screenshot from 2021-01-04 17-58-37

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #410 (c9f4f74) into master (9f96b8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   29.90%   29.90%           
=======================================
  Files          24       24           
  Lines        2170     2170           
=======================================
  Hits          649      649           
  Misses       1445     1445           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f96b8b...c9f4f74. Read the comment docs.

provisioner nat setup for workers

provisioner nat setup for workers
@Cbkhare Cbkhare force-pushed the nat_for_workers_#31 branch from 50a27e0 to c9f4f74 Compare January 4, 2021 12:23
@Cbkhare Cbkhare requested a review from gauravgahlot January 4, 2021 12:24
@mmlb
Copy link
Contributor

mmlb commented Jan 4, 2021

@Cbkhare can you reproduce this in tinkerbell/sandbox too please?

mergify bot added a commit to tinkerbell/playground that referenced this pull request Jan 7, 2021
## Description

Provisioner NAT setup for workers 

## Why is this needed

internet access on workers 
#31 


Fixes: #

## How Has This Been Tested?

- workflow executed successfully.
- ping from workers works correctly.

PR in reference with tinkerbell/tink#410
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
## Description

Provisioner NAT setup for workers 

## Why is this needed

internet access on workers 
tinkerbell#31 


Fixes: #

## How Has This Been Tested?

- workflow executed successfully.
- ping from workers works correctly.

PR in reference with tinkerbell/tink#410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants