-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
while setting up provisioner, check if osie file path is valid #411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 32.70% 32.70%
=======================================
Files 44 44
Lines 3137 3137
=======================================
Hits 1026 1026
Misses 2019 2019
Partials 92 92 Continue to review full report at Codecov.
|
Shouldn't this already be caught by |
@mmlb , right, I think the script is not bailing out in that case. With this PR it goes for a graceful exit. |
c286026
to
fb39845
Compare
Signed-off-by: Gaurav Gahlot <[email protected]>
fb39845
to
1bf3b3d
Compare
This PR looks great! The DCO checker noticed that one of your git commits isn't signed properly - can you fix that so that this PR may be merged? https://github.com/tinkerbell/tink/pull/411/checks?check_run_id=2999422937 has instructions on how to fix this PR. |
@tstromberg I tried those steps already but didn't work. Will it be okay if I close this PR and create a new one? |
@gauravgahlot That would be great. I'll close out this one. |
Description
While creating provisioner, if
TB_OSIE_TAR
is set then osie file is extracted from the file whose location/absolute path is the value of this variable.Why is this needed
if
TB_OSIE_TAR
is set and the file is not present at the given path(value of TB_OSIE_TAR) workflow fails stating the Linux image is not found. Which is valid as osie directory underdeploy/state
would be empty.How Has This Been Tested?
By creating the provisioner.
Provisioner is not created if a tar file is present at the location defined in
TB_OSIE_TAR
.on success
On failure