RenderTemplate using the text/template package, not the html one #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2021 21:58
Signed-off-by: Gianluca Arbezzano <[email protected]>
A template does not need to be rendered with HTML escape, or at least not at that layer. It was a mistake probably caused by a wrong goimport. Signed-off-by: Gianluca Arbezzano <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 33.04% 33.08% +0.04%
==========================================
Files 24 24
Lines 2170 2170
==========================================
+ Hits 717 718 +1
+ Misses 1377 1376 -1
Partials 76 76
Continue to review full report at Codecov.
|
invidian
previously approved these changes
Jan 15, 2021
gauravgahlot
suggested changes
Jan 15, 2021
By default the html/template rendered an empty string when a variable is not passed to the template.Execution. The text/template has a different behavior. By default it prints `<no value>`. With this configuration now it errors and tells that a variable is missed Signed-off-by: Gianluca Arbezzano <[email protected]>
invidian
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently, we imported the wrong package, we need to use text no HTML rules.
Why is this needed
Wrong import, we do not need to escape following HTML rules.
Fixes: #415
How Has This Been Tested?
Unit test
Checklist:
I have: