Build container binaries outside of docker #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
force-pushed
the
build-container-binaries-outside-docker
branch
from
71f5d87 to
a9be8dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 33.08% 33.08%
=======================================
Files 24 24
Lines 2170 2170
=======================================
Hits 718 718
Misses 1376 1376
Partials 76 76 Continue to review full report at Codecov.
|
mmlb
changed the title
mmlb
force-pushed
the
build-container-binaries-outside-docker
branch
4 times, most recently
from
46ebdac to
68e87eb
Compare
|
With this PR we get CI result in 1/2 the time! |
I tend to like $() for functions and ${} for variables similar to bash,
but make doesn't differentiate. $() has better syntax highlighting though
so there's that :D.
Signed-off-by: Manuel Mendez <[email protected]>
Change variables to be defined with `:=` so they are "Simply expanded variables" and not recursive... which basically just means they are evaluated immediately instead of when used. This is the least surprising behavior. While here I changed the names of some variables so its shorter and a little clearer. I also dropped use of GOOS as it doesn't seem used and moved CGO_ENABLED out of the recipe since it'll be re-used soon. Signed-off-by: Manuel Mendez <[email protected]>
Better settings for a better time. Signed-off-by: Manuel Mendez <[email protected]>
Use the full name instead of the package path/dir name. Makes things easier to do the crosscompile case later. Signed-off-by: Manuel Mendez <[email protected]>
Build all the binaries! Signed-off-by: Manuel Mendez <[email protected]>
DRY ftw. Signed-off-by: Manuel Mendez <[email protected]>
This is much faster than building in docker. Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
build-container-binaries-outside-docker
branch
from
68e87eb to
24ee42e
Compare
gianarb
approved these changes
Jan 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds the binaries used in the docker images outside of docker.
Why is this needed
Fixes: #368
How Has This Been Tested?
Checked the built binaries with
file.