Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixfmt #427

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Nixfmt #427

merged 3 commits into from
Feb 2, 2021

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Feb 1, 2021

Description

Add nixfmt to shell.nix so we can check its formatting.

Why is this needed

Like any fmt-esque tool, its output may differ between different revisions. So let's guard against that.

How Has This Been Tested?

CI.

How are existing users impacted? What migration steps/scripts do we need?

N/A

@mmlb mmlb requested a review from gianarb February 1, 2021 21:52
mmlb added 3 commits February 1, 2021 16:53
So we have a common version of nixfmt and avoid
going back and forth formatting shell.nix :D.

Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #427 (365950b) into master (873b0e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files          46       46           
  Lines        2865     2865           
=======================================
  Hits          984      984           
  Misses       1794     1794           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873b0e2...43b40d3. Read the comment docs.

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Feb 2, 2021
@mergify mergify bot merged commit b24fdf4 into tinkerbell:master Feb 2, 2021
@mmlb mmlb deleted the nixfmt branch November 12, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants