Fix permissions on downloaded artifacts: #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 34.34% 34.34%
=======================================
Files 46 46
Lines 2865 2865
=======================================
Hits 984 984
Misses 1794 1794
Partials 87 87 Continue to review full report at Codecov.
|
jacobweinstock
force-pushed
the
fix-permission-denied-in-all-images
branch
from
9a64bda to
7b8fbac
Compare
The Github Action actions/upload-artifact@v2 does not preserve file permissions on upload. https://github.com/actions/upload-artifact/tree/v2#permission-loss This almost certainly means all docker images, before this commit, are not working. Signed-off-by: Jacob Weinstock <[email protected]>
markjacksonfishing
previously approved these changes
Feb 3, 2021
jacobweinstock
force-pushed
the
fix-permission-denied-in-all-images
branch
from
7b8fbac to
5772933
Compare
markjacksonfishing
approved these changes
Feb 3, 2021
|
Not sure when this happened! But we need better CI for sure! I am scared!!
We use and test the image in Sandbox.. The last one we use there works:
```
$ docker run -it quay.io/tinkerbell/tink-cli:sha-57eb0efb /usr/bin/tink
tinkerbell CLI
Usage:
tink [command]
Available Commands:
events tink events client
hardware tink hardware client
help Help about any command
template tink template client
workflow tink workflow client
Flags:
-f, --facility string used to build grpc and http urls
-h, --help help for tink
-v, --version version for tink
Use "tink [command] --help" for more information about a command.
```
Something changes after this commit `57eb0efb`. Ok great I know 24ee42e
This means almost certainly all docker images, before this commit, are not working.
@jeremytanner this comment made me jump straight to my keyboard 😕
Thanks
|
|
Hmm agree we should probably do simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Github Action
actions/upload-artifact@v2does not preserve file permissions on upload. https://github.com/actions/upload-artifact/tree/v2#permission-lossThis means almost certainly all docker images, before this commit, are not working.
I have validated that with the latest tags, as shown here:
It's difficult to test this change. I think this will work but will need it to run in Github actions to actually know.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: