-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tink-server to cobra and viper #431
Conversation
@displague you did a similar job for the other binaries. Can you have a look and tell me if it makes sense? I know you don't like to keep "useless retro-compatibility" but the code will get removed soon trust me!! 😇 Thanks |
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 34.73% 34.82% +0.08%
==========================================
Files 47 47
Lines 2893 2886 -7
==========================================
Hits 1005 1005
+ Misses 1796 1789 -7
Partials 92 92
Continue to review full report at Codecov.
|
05605e8
to
afd27b5
Compare
71a8d4a
to
e9c3b74
Compare
e70bf26
to
87f1637
Compare
|
This PR refactors how tink-server starts. It uses Cobra and Viper same as tink-cli and tink-worker. Right now it tries to keep compatibility with the old way of doing things. Signed-off-by: Gianluca Arbezzano <[email protected]>
Signed-off-by: Gianluca Arbezzano <[email protected]>
e7aca40
to
550c63a
Compare
This PR refactors how tink-server starts.
It uses Cobra and Viper same as tink-cli and tink-worker.
Right now it tries to keep compatibility with the old way of doing
things.
TODO:
Unit test (project aborted, I don't know how to mock env var!)Signed-off-by: Gianluca Arbezzano [email protected]