Log to stderr to notify that CLI is looking for deprecated environment #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variable Get and delete cli command got rewritten to gain consistency. One of the additional features is better flag support. The gRPC connection to tink-server can now be changed via flags, but the warning who notified when the retro compatible and deprecated code get executed was not printed to stderr. Signed-off-by: Gianluca Arbezzano <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 34.82% 34.82%
=======================================
Files 47 47
Lines 2886 2886
=======================================
Hits 1005 1005
Misses 1789 1789
Partials 92 92
Continue to review full report at Codecov.
|
mmlb
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get and delete cli command got rewritten to gain consistency. One of the
additional features is better flag support.
The gRPC connection to tink-server can now be changed via flags, but the
warning who notified when the retro compatible and deprecated code get
executed was not printed to stderr.
Why is this needed
To be able to pipe the output of the command to other scripts or commands.