Tink CLI Template create should use --file instead of -p #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few weeks ago we decided to use --file for template creation: #385 But a few days days ago probably during a rebase I broke that behavior and left the template create command in a broken state 76793ee#diff-f5b9b4afa42ee036d5b6836337e9d6273de8c341267f7ea75eddc561f0ad6441 As detected by Dan #445 This commit should fix the issue, and it will require a documentation update as soon as we release a new version of sandbox. Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
force-pushed
the
fix/template_create_is_broken
branch
from
3601f74 to
f08f711
Compare
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 35.14% 35.14%
=======================================
Files 47 47
Lines 2888 2888
=======================================
Hits 1015 1015
Misses 1781 1781
Partials 92 92
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks ago we decided to use --file for template creation:
#385
But a few days ago probably during a rebase, I broke that
behavior and left the template to create command in a broken state
76793ee#diff-f5b9b4afa42ee036d5b6836337e9d6273de8c341267f7ea75eddc561f0ad6441
As detected by Dan #445
This commit should fix the issue, and it will require a documentation
update as soon as we release a new version of the sandbox.
Fixed #445