Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #484

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Update documentation #484

merged 3 commits into from
Apr 29, 2021

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented Apr 20, 2021 •
edited
Loading

Description

The documentation in the repository was last updated ages ago. This PR aims to bridge that documentation gap.

Checklist:

I have:

  • updated the documentation and/or roadmap
  • added unit or e2e tests
  • provided instructions on how to upgrade

@gauravgahlot gauravgahlot changed the title update stack details Update documentation Apr 20, 2021
@gauravgahlot gauravgahlot self-assigned this Apr 20, 2021
@gauravgahlot gauravgahlot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 20, 2021
@gauravgahlot gauravgahlot requested a review from thebsdbox April 20, 2021 14:07
@codecov
Copy link

codecov bot commented Apr 20, 2021 •
edited
Loading

Codecov Report

Merging #484 (834dee1) into master (89f7a80) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   32.70%   32.70%           
=======================================
  Files          44       44           
  Lines        3137     3137           
=======================================
  Hits         1026     1026           
  Misses       2019     2019           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f7a80...834dee1. Read the comment docs.

thebsdbox
thebsdbox previously approved these changes Apr 20, 2021
View reviewed changes
@gauravgahlot
update stack details
7f6d3b2 
Signed-off-by: Gaurav Gahlot <[email protected]>
@gauravgahlot
update contributing guideline
971e174 
Signed-off-by: Gaurav Gahlot <[email protected]>
@gauravgahlot
run Prettier
834dee1 
Signed-off-by: Gaurav Gahlot <[email protected]>
thebsdbox
thebsdbox approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent !

@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Apr 29, 2021
@mergify mergify bot merged commit 836244b into tinkerbell:master Apr 29, 2021
@gauravgahlot gauravgahlot deleted the docs branch April 29, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjacksonfishing markjacksonfishing markjacksonfishing approved these changes

@thebsdbox thebsdbox thebsdbox approved these changes

Assignees

@gauravgahlot gauravgahlot

Labels
kind/documentation Categorizes issue or PR as related to documentation. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauravgahlot @thebsdbox @markjacksonfishing