Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PostgreSQL 14 #552

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

rgl
Copy link
Contributor

@rgl rgl commented Oct 12, 2021

Description

Upgrade to PostgreSQL 14.

Why is this needed

Besides all the major improvements made from PostgreSQL 10 to 14, there is one particular feature that I wanted to use:

A nicer way to work with JSON, like the hardware data model :-)

Fixes: #551

The sandbox MR is at tinkerbell/playground#110.

How Has This Been Tested?

Besides the unit tests executed by CI, I've successfully tested this locally in a sandbox, and PostgreSQL 14 is now running:

root@provisioner:~# docker exec -i compose-db-1 psql -U tinkerbell -A -c 'select version()'
version
PostgreSQL 14.0 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424, 64-bit
(1 row)

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #552 (88615b0) into main (8208713) will not change coverage.
The diff coverage is n/a.

❗ Current head 88615b0 differs from pull request most recent head 6424388. Consider uploading reports for the commit 6424388 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files          44       44           
  Lines        3348     3348           
=======================================
  Hits         1164     1164           
  Misses       2085     2085           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8208713...6424388. Read the comment docs.

@nshalman
Copy link
Member

nshalman commented Oct 19, 2021

I'm not sure why the DCO check isn't happy with your PRs. @rgl, any chance of updating this branch and getting the DCO check happy so that we can merge this?

@rgl rgl force-pushed the rgl-upgrade-to-postgres-14 branch from a4304ca to 27213af Compare October 19, 2021 18:08
@rgl
Copy link
Contributor Author

rgl commented Oct 19, 2021

@nshalman, it should work now. I'm not yet sure of what I'm doing wrong, but I'm always tripping the Sign-Off stuff, sorry about that.

@mmlb mmlb force-pushed the rgl-upgrade-to-postgres-14 branch from 27213af to 6424388 Compare November 2, 2021 18:58
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Nov 2, 2021
@mergify mergify bot merged commit 187a3c7 into tinkerbell:main Nov 2, 2021
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to PostgreSQL 14
4 participants