-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shell.nix (fixes Mac) #562
Conversation
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 34.76% 34.76%
=======================================
Files 44 44
Lines 3348 3348
=======================================
Hits 1164 1164
Misses 2085 2085
Partials 99 99 Continue to review full report at Codecov.
|
Can you provide some more detail wrt what was broken please (in the commit message). I wonder if maybe applicable to other repos too. |
Also clean up a lint error in .golanci.yml Signed-off-by: Nahum Shalman <[email protected]>
Signed-off-by: Nahum Shalman <[email protected]>
Updated in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
Update shell.nix
Why is this needed
nix-shell
was broken on Mac:How Has This Been Tested?
nix-shell
on both Mac and LinuxHow are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have: