Add controller-gen to tools.go #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhausler
previously approved these changes
Dec 3, 2021
| paths=./pkg/apis/... \ | ||
| crd:crdVersions=v1 \ | ||
| rbac:roleName=manager-role \ | ||
| output:crd:dir=./config/crd/bases \ | ||
| output:webhook:dir=./config/webhook \ | ||
| webhook | ||
| prettier --write ./config/crd/ |
There was a problem hiding this comment.
:nod: but now I have to fix ci.
mmlb
force-pushed
the
add-controller-gen-to-tools.go
branch
from
2714c3a to
5476143
Compare
mmlb
force-pushed
the
add-controller-gen-to-tools.go
branch
from
5476143 to
a50aec7
Compare
This way we can use the go tool's built in pinning functionality that is already used in this project. Signed-off-by: Manuel Mendez <[email protected]>
Next commit is going to add prettier to one of the generated recipes and it's not available outside of nix-shell here. Signed-off-by: Manuel Mendez <[email protected]>
No need to have 2 different ways to manage go based tooling, we already have tools.go based install using simple `go install` calls. This also has the benefit that make has proper knowledge of the dependency on the binary and how to generate it so we don't need to do recursive make which is harmful. Signed-off-by: Manuel Mendez <[email protected]>
It is no longer needed. Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
add-controller-gen-to-tools.go
branch
from
a50aec7 to
4ab4f75
Compare
To get more accurate numbers of timing for the actual action. Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 34.76% 34.76%
=======================================
Files 44 44
Lines 3348 3348
=======================================
Hits 1164 1164
Misses 2085 2085
Partials 99 99 Continue to review full report at Codecov.
|
ScottGarman
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies most of kube.mk to be better integrated with tools.go and accompanying make rules.
Why is this needed
Gets rid of recursive make calls (which are considered harmful 😄) by giving make more/better info.
Also removes code that is no longer necessary (and some that never was, envsubst in kube.mk).
How Has This Been Tested?
I ran
make generate