escape pgsql field and values generated by buildGetCondition #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
previously approved these changes
Jan 25, 2022
|
@mergify rebase |
|
@cprivite is not allowed to run commands Hey, I reacted but my real name is @Mergifyio |
Oh well, I tried. |
Signed-off-by: Marques Johansson <[email protected]>
|
rebased on top of latest main |
mmlb
approved these changes
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 38.52% 38.52%
=======================================
Files 53 53
Lines 3561 3561
=======================================
Hits 1372 1372
Misses 2092 2092
Partials 97 97
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SQL column names and values should be escaped. Go does not offer a generic function for this (as it tends to be SQL dialect specific). The "pq" library, which we are using as a Postgresql interface, does provide helpers for this purpose.
https://pkg.go.dev/github.com/lib/pq#QuoteIdentifier
Alternatively,
buildGetConditionis only used by one caller. It should be possible to removebuildGetConditionand haveGetTemplatebuild a parameterized query with a parameterized list (some SQLs or client libraries don't allow for field names to be parameters, I don't know if that is the case here).Why is this needed
Fixes: #574
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: