mergify: Change docker-images check more explicit #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottGarman
previously approved these changes
Jan 19, 2022
The previous check was never matching because mergify was not being given the name of the matrix job, it is only given the realized name for each matrix instance. We also need to spell each matrix permuation we care about instead of `check-success~=docker-image` because mergify will happily merge once the first image build succeeds, it has not way to know it needs to wait for all of them. Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
fix-mergify-docker-images-check
branch
from
a518390 to
862c727
Compare
|
Rebased on top of main after #582 was merged, PTAL again @ScottGarman |
ScottGarman
approved these changes
Jan 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 36.01% 36.01%
=======================================
Files 44 44
Lines 3207 3207
=======================================
Hits 1155 1155
Misses 1959 1959
Partials 93 93 Continue to review full report at Codecov.
|
splaspood
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add one explicit
check-successcondition for each of the docker-image actions.Why is this needed
The previous check was never matching because mergify was not being given the name of the matrix job, it is only given the realized name for each matrix instance.
We also need to spell each matrix permuation we care about instead of
check-success~=docker-imagebecause mergify will happily merge once the first image build succeeds, it has not way to know it needs to wait for all of them.How Has This Been Tested?
Verified to be valid using mergify config editor