Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with tink template update using stdin #588

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Feb 9, 2022

Description

Fixes an issue with tink template update using stdin, follow up to #587

Why is this needed

#587 didn't fully add support for sdin with tink template update, it still threw an error if content wasn't provided using the --path argument.

How Has This Been Tested?

Tested manually against a Tinkerbell environment created using HEAD of sandbox

How are existing users impacted? What migration steps/scripts do we need?

Existing users not impacted

@detiber
Copy link
Contributor Author

detiber commented Feb 9, 2022

@mmlb a quick update for #587 that I noticed after finishing up manual testing

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #588 (7d18954) into main (03a3d54) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 7d18954 differs from pull request most recent head f0988a2. Consider uploading reports for the commit f0988a2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   38.44%   38.48%   +0.04%     
==========================================
  Files          53       53              
  Lines        3569     3565       -4     
==========================================
  Hits         1372     1372              
+ Misses       2100     2096       -4     
  Partials       97       97              
Impacted Files Coverage Δ
cmd/tink-cli/cmd/template/update.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a3d54...f0988a2. Read the comment docs.

@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Feb 9, 2022
@mmlb
Copy link
Contributor

mmlb commented Feb 9, 2022

Thanks for the fix!

@mergify mergify bot merged commit f704d1c into tinkerbell:main Feb 9, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants