Get rid of verbose test runs #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do we clean the test cache? It should not be necessary (I haven't found it be necessary). Also get rid of -v as its just noisy and never useful. When there is not test failure I don't really care to see *all* the tests being run. Yet when there *is* a test failure we potentially have to scroll over all the passing tests just to get to the output of the failed one. Why fight go here? Go will expand the test output for the failed tests anyway so its just doesn't make any sense to run with -v. Signed-off-by: Manuel Mendez <[email protected]>
For easier parsing/reading/scanning. Signed-off-by: Manuel Mendez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage 43.41% 43.41%
=======================================
Files 51 51
Lines 3107 3107
=======================================
Hits 1349 1349
Misses 1673 1673
Partials 85 85 Continue to review full report at Codecov.
|
markjacksonfishing
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is mostly about getting rid of the
-vfor all thego testruns.Also gets rid of the cleaning the go test cache and adds some empty lines to ci.yaml.
Why is this needed
I got rid of
-vas its just not necessary and I feel actually hinders debugging failed tests. When the tests pass I don't really care to see all the tests passing, pretty sure everyone just takes it for granted that all the tests are run :D. But when a test fails then the-vactually hinders debugging because now you have to go and hunt for the failed test and it's output. Without the-vgo does the sane thing of only showing the verbose output of the failed test(s). So lets just get rid of the forced-v.I got rid of the
go clean -testcachecalls because I have not found it to be necessary in my day-to-day development. Pretty sure a required use ofgo clean -testcachewould be considered a bug in the golang/go. This change was introduced in 8ec0d84 without any reason so I'll just assume there wasn't one.How Has This Been Tested?
Lots of
make testandgo test ./...for a long time without any breakage.How are existing users impacted? What migration steps/scripts do we need?
Faster test runs (by avoiding re-testing unchanged code) and easier to find/debug test failures.
Checklist:
I have: