-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WorkflowContext methods to Workflow CRD #600
Conversation
fe5afaf
to
87ffc62
Compare
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
==========================================
- Coverage 45.59% 43.98% -1.61%
==========================================
Files 53 51 -2
Lines 3143 3167 +24
==========================================
- Hits 1433 1393 -40
- Misses 1624 1689 +65
+ Partials 86 85 -1
Continue to review full report at Codecov.
|
e7c107e
to
24e36a9
Compare
I love the stuff in workflow_methods.go. I've been growing increasingly more annoyed at slinging pb types around instead of proper go types and this file makes it more obvious why. Going to create an issue for dropping that and maybe lifting some of the stuff from workflow_methods.go over and out of just here. |
* Add WorkflowContext conversion func * Move FrozenTime to root of module Signed-off-by: Micah Hausler <[email protected]>
24e36a9
to
9485aef
Compare
Signed-off-by: Micah Hausler [email protected]
Description
/pkg
Why is this needed
This creates reusable logic for the gRPC server and other K8s client code (like boots).
Fixes: #
How Has This Been Tested?
Added unit tests for new methods and functions
How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have: