-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added virtual worker #602
Added virtual worker #602
Conversation
) | ||
|
||
func getRandHexStr(length int) string { | ||
r := rand.New(rand.NewSource(time.Now().UnixNano())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G404: Use of weak random number generator (math/rand instead of crypto/rand)
(at-me in a reply with help
or ignore
)
9aeacad
to
5417ada
Compare
Codecov Report
@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 45.86% 45.86%
=======================================
Files 56 56
Lines 3268 3268
=======================================
Hits 1499 1499
Misses 1686 1686
Partials 83 83 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5417ada
to
c291002
Compare
c291002
to
12adba2
Compare
12adba2
to
3921cb3
Compare
|
||
func getRandHexStr(length int) string { | ||
// intentionally weak RNG. This is only for fake output | ||
r := rand.New(rand.NewSource(time.Now().UnixNano())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G404: Use of weak random number generator (math/rand instead of crypto/rand)
(at-me in a reply with help
or ignore
)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
3921cb3
to
2c1045c
Compare
Signed-off-by: Micah Hausler <[email protected]>
2c1045c
to
c4d4735
Compare
Add virtual tink worker command
Description
Why is this needed
This worker is helpful if you want to test Tinkerbell API changes while not actually executing a worker that executes docker containers.
Fixes: #
How Has This Been Tested?
Tested locally against the Tinkerbell API. I'll have an E2E test in a future PR that uses the no-op logger and container manager.
How are existing users impacted? What migration steps/scripts do we need?
No impact to existing users.
Checklist:
I have: