[tink worker] Make registry CLI flags optional #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional: A previous commit allowed an empty registry to be used when running a tink worker action. This allows tink worker to take advantage of that update by not requiring these registry CLI flags. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 45.86% 45.86%
=======================================
Files 56 56
Lines 3268 3268
=======================================
Hits 1499 1499
Misses 1686 1686
Partials 83 83 Continue to review full report at Codecov.
|
mmlb
approved these changes
Apr 25, 2022
jacobweinstock
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
docker-registry,registry-username, andregistry-passwordCLI flags optional:A previous commit allowed an empty registry to be used when running a tink worker action. This allows tink worker to take advantage of that update by not requiring these registry CLI flags.
Currently, if these values are not passed in via
/proc/cmdlinethen tink worker will fail to start.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: