Add make targets to generate release Kubernetes manifests #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavmpandey08
force-pushed
the
generate-manifests
branch
3 times, most recently
from
5c8bc11 to
6e47879
Compare
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 44.37% 44.37%
=======================================
Files 61 61
Lines 3491 3491
=======================================
Hits 1549 1549
Misses 1858 1858
Partials 84 84 Continue to review full report at Codecov.
|
abhinavmpandey08
force-pushed
the
generate-manifests
branch
from
6e47879 to
8e8f372
Compare
kube.mk
Outdated
| $(RELEASE_DIR): | ||
| mkdir -p $(RELEASE_DIR)/ | ||
|
|
||
| REGISTRY ?= ghcr.io |
There was a problem hiding this comment.
should this be quay.io/tinkerbell?
…rver and tink-controller Signed-off-by: Abhinav Pandey <[email protected]>
abhinavmpandey08
force-pushed
the
generate-manifests
branch
from
8e8f372 to
a1906ff
Compare
jacobweinstock
approved these changes
May 3, 2022
mmlb
reviewed
May 3, 2022
|
|
||
| .PHONY: release | ||
| release: clean-release | ||
| $(MAKE) set-manager-manifest-image MANIFEST_IMG=$(REGISTRY)/$(TINK_SERVER_IMAGE_NAME) MANIFEST_TAG=$(TINK_CONTROLLER_IMAGE_TAG) |
There was a problem hiding this comment.
Hey @abhinavmpandey08 was this supposed to be TINK_CONTROLLER_IMAGE_TAG?
mergify bot
added a commit
that referenced
this pull request
May 3, 2022
## Description #613 introduced a few unwanted bits and a typo. ## Why is this needed #613 did not use tools.go setup we have for using pinned go tools. I reworked it so it also didn't do recursive make as that is considered harmful and setup better dependencies so that we let make be better equipped to do the right thing. This way we avoid using make as a dumb command runner, which if not done can lead to racy/broken makefiles (see hook for example). I fixed a typo that would cause the manager to use tink-server image, likely to not work :D. In the process I noticed that we don't have `generate-manifests` hooked up to be run as part of ci to detect drift, so I added it as a dependency of `generated` as it should have been from the beginning. ## How Has This Been Tested? I ran make a bunch.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Makefile target
releaseto generate Kubernetes manifests fortink-serverandtink-controllerWhy is this needed
This is needed to generate the release manifests using
kustomizeHow Has This Been Tested?
Ran
make releaseand verified that the manifest gets generated properlyHow are existing users impacted? What migration steps/scripts do we need?
No user impact
Checklist:
I have: