Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Kubernetes API flag name #619

Merged
merged 1 commit into from
May 5, 2022

Conversation

micahhausler
Copy link
Contributor

Description

Kubernetes auto-injects certain environment variables into pods for service discovery, and the KUBERNETES env var is defined for all pods in all namespaces with the service IP of the API server. Because we already support viper environment variable mappings for flags, changing the flag name here will automatically support the in-cluster Kubernetes client configuration

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #619 (fee17e4) into main (c9ebfa8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files          61       61           
  Lines        3509     3509           
=======================================
  Hits         1567     1567           
  Misses       1860     1860           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ebfa8...fee17e4. Read the comment docs.

@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label May 5, 2022
@mergify mergify bot merged commit f48c79b into tinkerbell:main May 5, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants