Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building 32b flavors #626

Merged
merged 1 commit into from
May 24, 2022

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented May 20, 2022

Fixes #625

@chrisdoherty4 chrisdoherty4 force-pushed the feature/remove-32b-flavors branch from c684a46 to 9538cb8 Compare May 20, 2022 17:23
@chrisdoherty4 chrisdoherty4 requested review from micahhausler, mmlb and jacobweinstock and removed request for micahhausler May 20, 2022 17:26
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #626 (fcf54b3) into main (9bb6d05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   44.52%   44.52%           
=======================================
  Files          61       61           
  Lines        3519     3519           
=======================================
  Hits         1567     1567           
  Misses       1870     1870           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb6d05...fcf54b3. Read the comment docs.

Signed-off-by: Chris Doherty <[email protected]>
@jacobweinstock jacobweinstock force-pushed the feature/remove-32b-flavors branch from 9538cb8 to fcf54b3 Compare May 24, 2022 23:04
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label May 24, 2022
@mergify mergify bot merged commit 0a800a4 into tinkerbell:main May 24, 2022
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
mergify bot added a commit that referenced this pull request Aug 29, 2022
I'm a maintainer of several other services often related to the Kuberenetes back-end/Kubernetes controllers and I'm taking ownership for a lot of release synchronization making it both appropriate and necessary for me to maintain aspects of the Tink repository.

Requirements:

- I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md)
- I have [enabled 2FA on my GitHub account](https://github.com/settings/security)
- I have subscribed to the [tinkerbell-contributors e-mail list](https://groups.google.com/g/tinkerbell-contributors)
- I am actively contributing to 1 or more Tinkerbell subprojects

Here is a list of non-trival PRs I have been the primary reviewer on:

#596
#628
#614

I have also made a number of code contributions to this repository, here are a few of them:

#638
#631
#626
#622
#612

I have also raised various issues and am driving the releasing across Tinkerbell including in this repository.

Requesting consideration of expedited responsibilities: yes

Sponsors:

- @mmlb (Maintainer)
- @micahhausler (Maintainer)
- @jacobweinstock (Core contributor in other Tinkerbell repositories)
@chrisdoherty4 chrisdoherty4 deleted the feature/remove-32b-flavors branch May 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop building 32b flavors
3 participants