Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed hardware templating system #635

Merged
merged 7 commits into from
Aug 16, 2022
Merged

Conversation

srikarsganti
Copy link
Contributor

Signed-off-by: Srikar Ganti [email protected]

Description

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #635 (41a5fbe) into main (cf88a1f) will increase coverage by 0.28%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   44.66%   44.95%   +0.28%     
==========================================
  Files          61       61              
  Lines        3522     3546      +24     
==========================================
+ Hits         1573     1594      +21     
- Misses       1868     1870       +2     
- Partials       81       82       +1     
Impacted Files Coverage Δ
pkg/apis/core/v1alpha1/workflow_types.go 100.00% <ø> (ø)
pkg/controllers/workflow/controller.go 79.31% <88.88%> (+3.11%) ⬆️
workflow/template_validator.go 95.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobweinstock jacobweinstock added this to the 0.7.0 milestone Aug 16, 2022
@displague displague mentioned this pull request Aug 16, 2022
Signed-off-by: Srikar Ganti <[email protected]>
@jacobweinstock jacobweinstock self-requested a review August 16, 2022 18:33
Signed-off-by: Srikar Ganti <[email protected]>
Signed-off-by: Srikar Ganti <[email protected]>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Aug 16, 2022
@mergify mergify bot merged commit a0e9350 into tinkerbell:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants