Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag selection on cli make target #648

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

electrocucaracha
Copy link
Contributor

Description

This change reduces the number of output displayed by git tag command.

Why is this needed

Some commits (like 9c098c1) contains multiple tags, causing issues during the execution of make cli.

How Has This Been Tested?

$ git clone --depth 1 -b v0.8.0 https://github.com/tinkerbell/tink /tmp/tink
$ cd /tmp/tink
$ make cli

How are existing users impacted? What migration steps/scripts do we need?

NA

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #648 (4978e6b) into main (9c098c1) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   44.84%   45.09%   +0.24%     
==========================================
  Files          62       62              
  Lines        3532     3559      +27     
==========================================
+ Hits         1584     1605      +21     
- Misses       1866     1872       +6     
  Partials       82       82              
Impacted Files Coverage Δ
pkg/apis/core/v1alpha1/workflow_methods.go 76.27% <0.00%> (+1.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you @electrocucaracha!

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Nov 4, 2022
@mergify mergify bot merged commit 9df0dad into tinkerbell:main Nov 4, 2022
@electrocucaracha electrocucaracha deleted the fix-make_cli branch November 4, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants