Simplify and tidy Makefile #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feat/tidy-makefile
branch
from
17d0c1c to
8926498
Compare
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 20 20
Lines 1017 1017
=======================================
Hits 497 497
Misses 514 514
Partials 6 6 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feat/tidy-makefile
branch
5 times, most recently
from
40efec6 to
8b97351
Compare
chrisdoherty4
force-pushed
the
feat/tidy-makefile
branch
3 times, most recently
from
4c77edd to
a254da2
Compare
chrisdoherty4
force-pushed
the
feat/tidy-makefile
branch
2 times, most recently
from
b507e58 to
c0db08d
Compare
Signed-off-by: Chris Doherty <[email protected]>
chrisdoherty4
force-pushed
the
feat/tidy-makefile
branch
from
c0db08d to
5e45a3c
Compare
jacobweinstock
approved these changes
Dec 23, 2022
jacobweinstock
added
ready-to-merge
|
@mergify queue |
|
Sorry but this command cannot run when the configuration is updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project Makefile had lots of targets some of which perform duplicate functions and are, at times, tough to reconcile.
This PR seeks to simplify the targets used and clearly document how they work for future maintainers.
There's too much happening to explain in detail. In summary:
buildcan be used to build all binaries and supports cross platform builds with GOOS and GOARCH.tink-serveretc targets.images-imagee.g.tink-server-image.