Cleanup controller gen and proto gen #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feat/cleanup
branch
2 times, most recently
from
4fdd3d6 to
ae87efa
Compare
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 50.96% 51.17% +0.20%
==========================================
Files 19 18 -1
Lines 985 981 -4
==========================================
Hits 502 502
+ Misses 477 473 -4
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feat/cleanup
branch
2 times, most recently
from
13adfa3 to
e7a441e
Compare
Controller gen has an opinionated directory structure that doesn't typically compliment Go guidelines on project structure. This change tidies controller sources used for code gen to better align with Go project structure best practice. Additionally, the proto files that are generated and only used internally have been moved to `internal`. Signed-off-by: Chris Doherty <[email protected]>
chrisdoherty4
force-pushed
the
feat/cleanup
branch
from
2bc83b8 to
80358d3
Compare
jacobweinstock
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller gen has an opinionated directory structure that doesn't typically compliment Go guidelines on project structure. This change tidies controller sources used for code gen to better align with Go project structure best practice.
Additionally, the proto files that are generated and only used internally have been moved to
internalalong with much of the controller code.This PR does not address exported APIs that are only used by the packages they reside in or other similar anti-patterns. Similarly, this PR does not seek to change any types/type structures meaning consumers can merely change the import path and expect the imports to continue to work.
Signed-off-by: Chris Doherty [email protected]