General clean up to the /internal/workflow pkg #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Doherty <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 51.17% 48.26% -2.91%
==========================================
Files 18 18
Lines 981 951 -30
==========================================
- Hits 502 459 -43
- Misses 473 484 +11
- Partials 6 8 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jacobweinstock
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/internal/workflowpackage contains data structures for workflow handling that were previously split across the code base. This change applies some best practices by unexporting unnecessarily exported names and tweaks some algorithms to simplify logic. Finally it removes functions that aren't used anywhere in the project.