Adding a default value for hardware metadata state #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 48.26% 48.26%
=======================================
Files 18 18
Lines 951 951
=======================================
Hits 459 459
Misses 484 484
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Aravind Ramalingam <[email protected]>
pokearu
force-pushed
the
hw-state-default
branch
from
1f90433 to
0955770
Compare
mitalipaygude
approved these changes
Jan 17, 2023
chrisdoherty4
approved these changes
Jan 17, 2023
jacobweinstock
added a commit
to jacobweinstock/tink
that referenced
this pull request
Jun 26, 2024
This default value doesn't make sense from a holistic point of view. It was added as part of some CAPT refactoring. tinkerbell#669 If CAPT needs this state then the responsibility is on CAPT to set this. Also, this field is no longer used by Smee or CAPT. Signed-off-by: Jacob Weinstock <[email protected]>
3 tasks
jacobweinstock
added a commit
to jacobweinstock/tink
that referenced
this pull request
Jul 1, 2024
This default value doesn't make sense from a holistic point of view. It was added as part of some CAPT refactoring. tinkerbell#669 If CAPT needs this state then the responsibility is on CAPT to set this. Also, this field is no longer used by Smee or CAPT. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
added a commit
to jacobweinstock/tink
that referenced
this pull request
Jul 5, 2024
This default value doesn't make sense from a holistic point of view. It was added as part of some CAPT refactoring. tinkerbell#669 If CAPT needs this state then the responsibility is on CAPT to set this. Also, this field is no longer used by Smee or CAPT. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
added a commit
that referenced
this pull request
Jul 5, 2024
Remove default value for Hardware.Spec.Metadata.State: ## Description <!--- Please describe what this PR is going to change --> This default value doesn't make sense from a holistic point of view. Apply a Hardware object to a cluster doesn't by default indicate the hardware is in a provisioning state and we should not assume this with a default value. It was added as part of some CAPT refactoring. #669 If CAPT needs this state then the responsibility is on CAPT to set this. Also, this field is no longer used by Smee or CAPT. ## Why is this needed <!--- Link to issue you have raised --> Fixes: # ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## How are existing users impacted? What migration steps/scripts do we need? <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The metadata state field is consumed in CAPT for checking if a given hardware is ready.
The changes sets a default value for the field to
provisioningwith kubebuilder defaults. Currently this field is left empty.Why is this needed
Boots and CAPT looks at
spec.metadata.stateto check if a hardware needs to be PXE served and if a hardware is ready.Today a user is not expected to set the field but defaulting to
provisioninghelps provide context to the starting state of the tinkerbell provisioning process.