Refactor reconcilers and controller manager construction logic #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes tidy up the tinker controller implementation in several ways:
NewManager
function with the workflow controller pre-registerred.manager.Manager
dependency in the Tink Server with acluster.Cluster
. Cluster objects are only really concerned with providing an API to retrieve a client and facilitate caching unlike the manager object that's concerned with all components related to controllers, webhooks, leader election and more. This makes the cluster object more appropriate for the Tink Server.workflow.Controller
toworkflow.Reconciler
to be representative of the implementation. Controllers contain more than just reconciliation components.--metrics-bind-address
,--health-probe-bind-address
.