Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on packethost/pkg #677

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Mar 26, 2023

This change removes the dependency on the packethost/pkg module.

Additionally, it adjusts some of the construction logic in root commands to minimize the logic in main().

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #677 (bace48d) into main (edab44c) will not change coverage.
The diff coverage is 25.00%.

❗ Current head bace48d differs from pull request most recent head 35c8378. Consider uploading reports for the commit 35c8378 to get more accurate results

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files          18       18           
  Lines         860      860           
=======================================
  Hits          424      424           
  Misses        428      428           
  Partials        8        8           
Impacted Files Coverage Δ
cmd/tink-worker/worker/registry.go 80.76% <0.00%> (ø)
cmd/tink-worker/worker/worker.go 0.00% <0.00%> (ø)
internal/server/kubernetes_api.go 0.00% <0.00%> (ø)
internal/server/kubernetes_api_workflow.go 30.15% <0.00%> (ø)
cmd/tink-worker/worker/container_manager.go 97.36% <88.88%> (ø)
cmd/tink-worker/worker/log_capturer.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 force-pushed the chore/logr branch 3 times, most recently from 6729014 to 7570475 Compare March 26, 2023 02:14
@chrisdoherty4 chrisdoherty4 changed the title Replace packethost/pkg/logger with logr Remove dependency on packethost/pkg Mar 26, 2023
@chrisdoherty4 chrisdoherty4 force-pushed the chore/logr branch 2 times, most recently from 1a1a91c to 8eacb5f Compare March 26, 2023 03:46
jacobweinstock
jacobweinstock previously approved these changes Mar 28, 2023
@mergify mergify bot merged commit f3d2cf6 into tinkerbell:main Mar 28, 2023
@chrisdoherty4 chrisdoherty4 deleted the chore/logr branch May 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants