Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cmd validation for v1alpha2 Template commands #695

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

chrisdoherty4
Copy link
Member

We expect action commands configured on templates to be unix paths that reference an executable. This adds a validation to ensure its a single path.

The command will translate in implementation to a Docker entrypoint which has 2 forms. We're only allowing a single argument as the entrypoint that can accept a number of args <cmd> <arg1> ...<argN> for simplicity.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #695 (538ab67) into main (d8f27a7) will not change coverage.
The diff coverage is n/a.

❗ Current head 538ab67 differs from pull request most recent head 03aafc9. Consider uploading reports for the commit 03aafc9 to get more accurate results

@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files          18       18           
  Lines         860      860           
=======================================
  Hits          424      424           
  Misses        428      428           
  Partials        8        8           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label Apr 10, 2023
@chrisdoherty4 chrisdoherty4 force-pushed the feature/cmd-validation branch from 937e44b to 03aafc9 Compare April 10, 2023 17:27
@mergify mergify bot merged commit f017f99 into tinkerbell:main Apr 10, 2023
@chrisdoherty4 chrisdoherty4 deleted the feature/cmd-validation branch May 15, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants