Move ci-checks.sh to a make target: #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 55.54% 55.54%
=======================================
Files 26 26
Lines 1100 1100
=======================================
Hits 611 611
Misses 474 474
Partials 15 15 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This allows us to check for nix-shell and use docker if nix-shell is not installed. Update CI to use the make target. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
make-target-ci-checks
branch
from
57fcd75 to
307de72
Compare
chrisdoherty4
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to check for nix-shell and use docker if nix-shell is not installed. Update CI to use the make target.
Why is this needed
Fixes: #556
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: