Add tink-agent binary #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feature/agent
branch
2 times, most recently
from
365f016 to
d708e47
Compare
Codecov Report
@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 51.70% 51.90% +0.20%
==========================================
Files 32 32
Lines 1441 1441
==========================================
+ Hits 745 748 +3
+ Misses 655 650 -5
- Partials 41 43 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feature/agent
branch
4 times, most recently
from
011e7d0 to
d1c781c
Compare
chrisdoherty4
commented
Jun 22, 2023
|
|
||
| flgs := cmd.Flags() | ||
| flgs.StringVar(&opts.AgentID, "agent-id", "", "An ID that uniquely identifies the agent instance") | ||
| flgs.StringVar(&opts.TinkServerAddr, "tink-server-addr", "127.0.0.1:42113", "Tink server address") |
There was a problem hiding this comment.
Not sure about the option here. It might be better to use grpc-addr complimenting the idea that we could have multiple transports. Introducing the file transport may inform us better.
chrisdoherty4
force-pushed
the
feature/agent
branch
from
d1c781c to
2946cc3
Compare
jacobweinstock
approved these changes
Jul 11, 2023
Signed-off-by: Chris Doherty <[email protected]>
jacobweinstock
force-pushed
the
feature/agent
branch
from
2946cc3 to
bc84381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #734
This PR adds the tink-agent binary to that includes minimal configuration to enable launching an agent with connectivity over gRPC to a server.