Add additional device naming formats to formatPartition template func
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestDockerImageNotPresent can fail if the alpine image is being used by a started container. The hello-world image might be a safer option. Signed-off-by: Jacob Weinstock <[email protected]>
This allows for using the formatPartition func for more device types. `vd*` is a device created by virtio. `hd*` for legacy IDE hard disks. Signed-off-by: Jacob Weinstock <[email protected]>
chrisdoherty4
approved these changes
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 51.90% 51.90%
=======================================
Files 32 32
Lines 1441 1441
=======================================
Hits 748 748
Misses 650 650
Partials 43 43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for using the formatPartition func for more device types.
vd*is a device created by virtio.hd*for legacy IDE hard disks.Also use
hello-worldimage instead ofalpinein theTestDockerImageNotPresentunit test.Why is this needed
Fixes: #770
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: