Fix multi-worker workflows:

[jacobweinstock]

Description

This fixes multi worker workflows. Previously, across workers, multitask workflows updating of the workflow status of each action after the first task didn't take previous tasks into account. Now it does.

Why is this needed

Fixes: #

How Has This Been Tested?

manually tested with Tink stack v0.4.3 helm chart.

Here's the template I tested with:

apiVersion: "tinkerbell.org/v1alpha1"
kind: Template
metadata:
  name: multiworker
  namespace: tink-system
spec:
  data: |
    version: "0.1"
    name: multiworker
    global_timeout: 9800
    tasks:
      - name: "task 1"
        worker: "{{.device_1}}"
        volumes:
          - /dev:/dev
          - /dev/console:/dev/console
          - /lib/firmware:/lib/firmware:ro
        actions:
          - name: "action 1"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
          - name: "action 2"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
          - name: "action 3"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
      - name: "task 2"
        worker: "{{.device_1}}"
        volumes:
          - /dev:/dev
          - /dev/console:/dev/console
          - /lib/firmware:/lib/firmware:ro
        actions:
          - name: "action 1"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
          - name: "action 2"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
          - name: "action 3"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
      - name: "task 3"
        worker: "{{.device_2}}"
        volumes:
          - /dev:/dev
          - /dev/console:/dev/console
          - /lib/firmware:/lib/firmware:ro
        actions:
          - name: "sleep 1"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
          - name: "sleep 2"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
      - name: "task 4"
        worker: "{{.device_2}}"
        volumes:
          - /dev:/dev
          - /dev/console:/dev/console
          - /lib/firmware:/lib/firmware:ro
        actions:
          - name: "action 1"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]
          - name: "action 2"
            image: alpine
            timeout: 120
            command: ["sleep", "2"]

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• added unit or e2e tests
• provided instructions on how to upgrade

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2c141f) 51.09% compared to head (af82c36) 51.23%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   51.09%   51.23%   +0.13%     
==========================================
  Files          33       33              
  Lines        1456     1460       +4     
==========================================
+ Hits          744      748       +4     
  Misses        666      666              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.